Skip to content

Make BWClientConfiguration use the builder pattern #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JasperGeurtz merged 1 commit into from
Oct 14, 2022
Merged

Make BWClientConfiguration use the builder pattern #81

JasperGeurtz merged 1 commit into from
Oct 14, 2022

Conversation

@JasperGeurtz
Copy link
Collaborator

@JasperGeurtz JasperGeurtz commented Oct 13, 2022

Let me know what you think @dgant . This way it will use a more usual Builder pattern, however it will be a small breaking change for you here: https://github.com/dgant/PurpleWave/blob/a199736923ca0809ab1a7312448f090ced6c9db6/src/Lifecycle/Main.scala#L19

Should just be a change to:

... = new BWClientConfiguration.Builder()
  .with...()
  ...
  .build()

@JasperGeurtz JasperGeurtz requested a review from dgant October 13, 2022 15:41
dgant
dgant reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@dgant dgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, much nicer to avoid the explicit locking step!

@JasperGeurtz JasperGeurtz merged commit 95b640d into develop Oct 14, 2022
@JasperGeurtz JasperGeurtz deleted the make-bwclientconfiguration-buildable branch October 28, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dgant dgant dgant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JasperGeurtz @dgant